maddiedawson commented on code in PR #42118: URL: https://github.com/apache/spark/pull/42118#discussion_r1275312626
########## python/pyspark/ml/deepspeed/tests/test_deepspeed_distributor.py: ########## @@ -14,13 +14,21 @@ # See the License for the specific language governing permissions and # limitations under the License. # +from contextlib import contextmanager import os import sys +import textwrap from typing import Any, Tuple, Dict + +import shutil import unittest +from pyspark import SparkConf, SparkContext from pyspark.ml.deepspeed.deepspeed_distributor import DeepspeedTorchDistributor - +from pyspark.ml.torch.distributor import TorchDistributor Review Comment: Remove this? The TorchDistributor itself doesn't seem to be used ########## python/pyspark/ml/deepspeed/tests/test_deepspeed_distributor.py: ########## @@ -14,13 +14,21 @@ # See the License for the specific language governing permissions and # limitations under the License. # +from contextlib import contextmanager import os import sys +import textwrap from typing import Any, Tuple, Dict + +import shutil import unittest +from pyspark import SparkConf, SparkContext from pyspark.ml.deepspeed.deepspeed_distributor import DeepspeedTorchDistributor - +from pyspark.ml.torch.distributor import TorchDistributor +from pyspark.sql import SparkSession +from pyspark.testing.utils import SPARK_HOME Review Comment: Remove, unused -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
