sarutak commented on code in PR #42085:
URL: https://github.com/apache/spark/pull/42085#discussion_r1277234850
##########
core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala:
##########
@@ -209,32 +204,24 @@ private[ui] class StagePage(parent: StagesTab, store:
AppStatusStore) extends We
val dagViz = UIUtils.showDagVizForStage(stageId, stageGraph)
val currentTime = System.currentTimeMillis()
- val taskTable = try {
- val _taskTable = new TaskPagedTable(
- stageData,
- UIUtils.prependBaseUri(request, parent.basePath) +
- s"/stages/stage/?id=${stageId}&attempt=${stageAttemptId}",
- pageSize = taskPageSize,
- sortColumn = taskSortColumn,
- desc = taskSortDesc,
- store = parent.store
- )
- _taskTable
- } catch {
- case e @ (_ : IllegalArgumentException | _ : IndexOutOfBoundsException)
=>
- null
- }
val content =
summary ++
dagViz ++ <div id="showAdditionalMetrics"></div> ++
makeTimeline(
// Only show the tasks in the table
- Option(taskTable).map({ taskPagedTable =>
+ () => {
+ val taskDataSource = new TaskDataSource(
Review Comment:
Can we also remove `TaskDataSource`? It seems to be used only in
`TaskPagedTable`.
##########
core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala:
##########
@@ -258,6 +245,8 @@ private[ui] class StagePage(parent: StagesTab, store:
AppStatusStore) extends We
if (!TIMELINE_ENABLED) return Seq.empty[Node]
+ val tasks = tasksFunc()
Review Comment:
Thank you. It's reasonable to avoid the calsulation if the timeline feature
is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
