sunchao commented on code in PR #42324:
URL: https://github.com/apache/spark/pull/42324#discussion_r1283687546
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -190,10 +190,17 @@ case class BatchScanExec(
Seq.fill(numSplits)(Seq.empty))
}
} else {
+ // either `commonPartitionValues` is not defined, or it is
defined but
+ // `applyPartialClustering` is false.
val partitionMapping = groupedPartitions.map { case (row, parts)
=>
InternalRowComparableWrapper(row, p.expressions) -> parts
}.toMap
- finalPartitions = p.partitionValues.map { partValue =>
+
+ // In case `commonPartitionValues` is not defined (e.g., SPJ is
not used), there
Review Comment:
Currently the SPJ logic in this class is pretty complicated, given it needs
to handle different combinations w.r.t partial clustering, partition value
pushing down as well as runtime filtering. We can try to simplify it in a
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
