LuciferYang commented on PR #42236: URL: https://github.com/apache/spark/pull/42236#issuecomment-1664828251
While I'm not certain if it's reasonable, I still want to point out that relocating the content of the `spark-protobuf` module may result to a poorer user experience: In order to use this sql function, users have no choice but to relocate the content of the Java PB description files used in their business according to Spark's project rules. Is this really user-friendly for existing data and businesses? Meanwhile, the `spark-protobuf` module is a module that won't be packaged into spark-client tar ball, is it very risky to only publish unshaded jars? @rangadi @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
