ueshin commented on code in PR #42371: URL: https://github.com/apache/spark/pull/42371#discussion_r1286461234
########## python/pyspark/sql/connect/session.py: ########## @@ -93,14 +94,13 @@ from pyspark.sql.connect.udtf import UDTFRegistration -# `_active_spark_session` stores the active spark connect session created by -# `SparkSession.builder.getOrCreate`. It is used by ML code. -# If sessions are created with `SparkSession.builder.create`, it stores -# The last created session -_active_spark_session = None - - class SparkSession: + # The active SparkSession for the current thread + _active_session = threading.local() Review Comment: I guess `ClassVar[threading.local]`? But ok, should be fine. I just wanted to have `mypy` check if instance methods don't update the variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org