cloud-fan commented on code in PR #41782:
URL: https://github.com/apache/spark/pull/41782#discussion_r1299550767
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java:
##########
@@ -846,7 +849,14 @@ public final void addElementsAppended(int num) {
/**
* Marks this column as being constant.
*/
- public final void setIsConstant() { isConstant = true; }
+ public final void setIsConstant() {
+ if (childColumns != null) {
+ for (WritableColumnVector c : childColumns) {
+ c.setIsConstant();
Review Comment:
This change make sense. Do you know why there was no problem before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
