heyihong commented on code in PR #42377:
URL: https://github.com/apache/spark/pull/42377#discussion_r1301851158
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2843,6 +2843,21 @@ object SQLConf {
// show full stacktrace in tests but hide in production by default.
.createWithDefault(Utils.isTesting)
+ val SPARK_ENRICH_ERROR_ENABLED =
+ buildConf("spark.sql.spark.enrichError.enabled")
+ .doc("When true, it enriches errors with full exception messages on the
client side.")
+ .version("3.5.0")
Review Comment:
`org.apache.spark.sql.connect.config.Connect` cannot be configured by
`spark.conf.set(...)` if I understand correctly?
Maybe we can name this to `spark.sql.connect.jvmStacktrace.enabled`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2843,6 +2843,21 @@ object SQLConf {
// show full stacktrace in tests but hide in production by default.
.createWithDefault(Utils.isTesting)
+ val SPARK_ENRICH_ERROR_ENABLED =
+ buildConf("spark.sql.spark.enrichError.enabled")
+ .doc("When true, it enriches errors with full exception messages on the
client side.")
+ .version("3.5.0")
Review Comment:
`org.apache.spark.sql.connect.config.Connect` cannot be configured by
`spark.conf.set(...)` if I understand correctly?
Maybe we can name this to `spark.sql.spark.enrichError.enabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
