mridulm commented on code in PR #42529:
URL: https://github.com/apache/spark/pull/42529#discussion_r1306701075
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:
##########
@@ -1618,9 +1618,9 @@ private[spark] object Client extends Logging {
return false
}
- val srcAuthority = srcUri.getAuthority()
- val dstAuthority = dstUri.getAuthority()
- if (srcAuthority != null && !srcAuthority.equalsIgnoreCase(dstAuthority)) {
+ val srcUserInfo = srcUri.getUserInfo()
+ val dstUserInfo = dstUri.getUserInfo()
+ if (srcUserInfo != null && !srcUserInfo.equalsIgnoreCase(dstUserInfo)) {
Review Comment:
This does not handle the case of `srcUserInfo == null && dstUserInfo != null`
Also, I am not sure if `equalsIgnoreCase` is right here btw ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
