jchen5 commented on code in PR #42725: URL: https://github.com/apache/spark/pull/42725#discussion_r1310660553
########## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ########## @@ -3751,4 +3751,14 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat "supported" -> "constant expressions"), cause = cause) } + + def unsupportedCorrelatedSubqueryExpressionInJoinConditionError( Review Comment: In my experience it's better not to add items at the end because if we need to backport/cherry-pick it creates tons of merge conflicts - better to add in the middle, perhaps near related confs in UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org