harupy commented on code in PR #42887:
URL: https://github.com/apache/spark/pull/42887#discussion_r1323909735
##########
python/pyspark/ml/tests/connect/test_legacy_mode_feature.py:
##########
@@ -57,8 +58,10 @@ def test_max_abs_scaler(self):
local_df1 = df1.toPandas()
local_fit_model = scaler.fit(local_df1)
+ local_df1_copy = local_df1.copy()
local_transform_result = local_fit_model.transform(local_df1)
- assert id(local_transform_result) == id(local_df1)
+ # assert that pandas dataframe input columns should be intact.
Review Comment:
```suggestion
# assert that `transform` doesn't mutate the input dataframe.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
