Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6390#discussion_r30955386
--- Diff:
core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala ---
@@ -62,6 +62,10 @@ class KryoSerializerSuite extends FunSuite with
SharedSparkContext {
val thrown3 = intercept[IllegalArgumentException](new
KryoSerializer(conf4).newInstance())
assert(thrown3.getMessage.contains(kryoBufferProperty))
assert(!thrown3.getMessage.contains(kryoBufferMaxProperty))
+ val conf5 = conf.clone()
+ conf5.set(kryoBufferProperty, "8m")
--- End diff --
Doesn't this show it currently works though? Is the resolution that there
was no problem (at least not in `master`)? More tests are good but this seems
like something already well exercised by tests above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
