viirya commented on code in PR #42936:
URL: https://github.com/apache/spark/pull/42936#discussion_r1326863283
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -844,8 +845,8 @@ private[deploy] class Master(
// We assign workers to each waiting driver in a round-robin fashion.
For each driver, we
// start from the last worker that was assigned a driver, and continue
onwards until we have
// explored all alive workers.
- var launched = false
- var isClusterIdle = true
+ var launched = (drivers.size - waitingDrivers.size) >= maxDrivers
Review Comment:
Got it. I just worry about the case that submitted drivers are silently
waiting there without any feedback to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
