neilramaswamy commented on code in PR #42895:
URL: https://github.com/apache/spark/pull/42895#discussion_r1327645005


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -135,17 +135,15 @@ private[sql] class HDFSBackedStateStoreProvider extends 
StateStoreProvider with
 
     /** Commit all the updates that have been made to the store, and return 
the new version. */
     override def commit(): Long = {
-      verify(state == UPDATING, "Cannot commit after already committed or 
aborted")
-
       try {
+        verify(state == UPDATING, "Cannot commit after already committed or 
aborted")
         commitUpdates(newVersion, mapToUpdate, compressedStream)
         state = COMMITTED
         logInfo(s"Committed version $newVersion for $this to file 
$finalDeltaFile")
         newVersion
       } catch {
-        case NonFatal(e) =>
-          throw new IllegalStateException(
-            s"Error committing version $newVersion into $this", e)

Review Comment:
   Yeah this is a good point, it does capture operator/partition/etc. Updated 
to log `this` now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to