Hisoka-X commented on code in PR #42952:
URL: https://github.com/apache/spark/pull/42952#discussion_r1327921121
##########
core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala:
##########
@@ -323,6 +339,23 @@ class SparkThrowableSuite extends SparkFunSuite {
assert(sqlErrorParentDoc.trim == commonErrorsInDoc.trim,
"The error class document is not up to date. Please regenerate it.")
}
+
+ val orphans = orphanedGoldenFiles()
+ if (regenerateGoldenFiles) {
+ if (orphans.nonEmpty) {
+ logInfo(s"Orphaned error class documents (${orphans.size}) is not
empty, " +
+ s"executing cleanup operation.")
+ orphans.foreach { f =>
+ FileUtils.deleteQuietly(f)
+ logInfo(s"Cleanup orphaned error document: ${f.getName}.")
+ }
+ } else {
+ logInfo(s"Orphaned error class documents is empty")
+ }
+ } else {
+ assert(orphans.isEmpty,
+ "Exist orphaned error class documents. Please regenerate it.")
Review Comment:
~~Maybe we can add `orphans` value in error msg. Then developers can also
just delete it by hands.~~
Ignore it. It already would print list at now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
