itholic commented on code in PR #42956: URL: https://github.com/apache/spark/pull/42956#discussion_r1328218762
########## python/pyspark/pandas/tests/connect/test_parity_internal.py: ########## @@ -15,18 +15,86 @@ # limitations under the License. # import unittest +import pandas as pd from pyspark.pandas.tests.test_internal import InternalFrameTestsMixin from pyspark.testing.connectutils import ReusedConnectTestCase from pyspark.testing.pandasutils import PandasOnSparkTestUtils +from pyspark.pandas.internal import ( + InternalFrame, + SPARK_DEFAULT_INDEX_NAME, + SPARK_INDEX_NAME_FORMAT, +) +from pyspark.pandas.utils import spark_column_equals class InternalFrameParityTests( InternalFrameTestsMixin, PandasOnSparkTestUtils, ReusedConnectTestCase ): - @unittest.skip("TODO(SPARK-43654): Enable InternalFrameParityTests.test_from_pandas.") def test_from_pandas(self): - super().test_from_pandas() + pdf = pd.DataFrame({"a": [1, 2, 3], "b": [4, 5, 6]}) Review Comment: Or maybe we can manually remove the backticks when comparing the Column `repr` for now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org