cdkrot commented on code in PR #42949: URL: https://github.com/apache/spark/pull/42949#discussion_r1328421040
########## python/pyspark/sql/connect/client/logging.py: ########## @@ -0,0 +1,43 @@ +import logging +import os +from typing import Optional + +__all__ = [ + "logger", Review Comment: logger isn't an API, yeah. I didn't import it in __init__, but probably best to drop it here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
