heyihong commented on code in PR #42377: URL: https://github.com/apache/spark/pull/42377#discussion_r1329328782
########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectFetchErrorDetailsHandler.scala: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.connect.service + +import io.grpc.stub.StreamObserver + +import org.apache.spark.connect.proto +import org.apache.spark.connect.proto.FetchErrorDetailsResponse +import org.apache.spark.sql.connect.config.Connect +import org.apache.spark.sql.connect.utils.ErrorUtils +import org.apache.spark.sql.internal.SQLConf + +class SparkConnectFetchErrorDetailsHandler( + responseObserver: StreamObserver[proto.FetchErrorDetailsResponse]) { + + def handle(v: proto.FetchErrorDetailsRequest): Unit = { + val sessionHolder = + SparkConnectService + .getOrCreateIsolatedSession(v.getUserContext.getUserId, v.getSessionId) + + val response = Option(sessionHolder.errorIdToError.getIfPresent(v.getErrorId)) + .map { error => + ErrorUtils.throwableToFetchErrorDetailsResponse( + st = error, + isTruncated = false, + serverStackTraceEnabled = + sessionHolder.session.conf.get(Connect.CONNECT_SERVER_STACKTRACE_ENABLED), + pySparkJVMStackTraceEnabled = + sessionHolder.session.conf.get(SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED), Review Comment: Connect.CONNECT_SERVER_STACKTRACE_ENABLED is a more language agnostic conf for returning stack trace. SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED is python client specific ########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectFetchErrorDetailsHandler.scala: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.connect.service + +import io.grpc.stub.StreamObserver + +import org.apache.spark.connect.proto +import org.apache.spark.connect.proto.FetchErrorDetailsResponse +import org.apache.spark.sql.connect.config.Connect +import org.apache.spark.sql.connect.utils.ErrorUtils +import org.apache.spark.sql.internal.SQLConf + +class SparkConnectFetchErrorDetailsHandler( + responseObserver: StreamObserver[proto.FetchErrorDetailsResponse]) { + + def handle(v: proto.FetchErrorDetailsRequest): Unit = { + val sessionHolder = + SparkConnectService + .getOrCreateIsolatedSession(v.getUserContext.getUserId, v.getSessionId) + + val response = Option(sessionHolder.errorIdToError.getIfPresent(v.getErrorId)) + .map { error => + ErrorUtils.throwableToFetchErrorDetailsResponse( + st = error, + isTruncated = false, + serverStackTraceEnabled = + sessionHolder.session.conf.get(Connect.CONNECT_SERVER_STACKTRACE_ENABLED), + pySparkJVMStackTraceEnabled = + sessionHolder.session.conf.get(SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED), Review Comment: Connect.CONNECT_SERVER_STACKTRACE_ENABLED is a language-agnostic conf for returning stack trace. SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED is python client specific -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
