heyihong commented on code in PR #42377: URL: https://github.com/apache/spark/pull/42377#discussion_r1330169939
########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala: ########## @@ -45,6 +46,13 @@ case class SessionHolder(userId: String, sessionId: String, session: SparkSessio private val executions: ConcurrentMap[String, ExecuteHolder] = new ConcurrentHashMap[String, ExecuteHolder]() + // The cache that maps an error id to a throwable. The throwable in cache is independent to + // each other. + val errorIdToError = + SparkConnectService + .cacheBuilder(ERROR_CACHE_SIZE, ERROR_CACHE_TIMEOUT_SEC) Review Comment: LRU. But errors will be invalidated after the first fetch request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org