mridulm commented on code in PR #42426:
URL: https://github.com/apache/spark/pull/42426#discussion_r1330362915
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java:
##########
@@ -274,7 +287,13 @@ private void handleBlockTransferFailure(String blockId,
Throwable exception) {
synchronized (RetryingBlockTransferor.this) {
if (this == currentListener && outstandingBlocksIds.contains(blockId))
{
if (shouldRetry(exception)) {
- initiateRetry(exception);
+ try {
+ initiateRetry(exception);
+ } catch (Throwable t) {
+ logger.error("Exception while trying to initiate retry", t);
Review Comment:
Do you mean push that to `initiateRetry` and return a boolean (or some such)
to indicate failure ?
Something like:
```
if (initiateRetry(exception)) {
return ;
} else {
outstandingBlocksIds.remove(blockId);
shouldForwardFailure = true;
}
```
And do a `try/catch` on `Throwable` around `initiateRetry` ?
(I misread your response @Ngone51 , hence my code snippet above for clarity
:) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
