cloud-fan commented on code in PR #42864: URL: https://github.com/apache/spark/pull/42864#discussion_r1331143291
########## sql/core/src/test/scala/org/apache/spark/sql/IntegratedUDFTestUtils.scala: ########## @@ -723,11 +728,14 @@ object IntegratedUDFTestUtils extends SQLHelper { override def builder(e: Seq[Expression]): Expression = { assert(e.length == 1, "Defined UDF only has one column") val expr = e.head - assert(expr.resolved, "column should be resolved to use the same type " + Review Comment: I'm a bit confused about this change. IIUC we always call `builder` with resolved expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org