beliefer commented on code in PR #42612: URL: https://github.com/apache/spark/pull/42612#discussion_r1331177757
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala: ########## @@ -279,7 +283,9 @@ case class StaticInvoke( inputTypes: Seq[AbstractDataType] = Nil, propagateNull: Boolean = true, returnNullable: Boolean = true, - isDeterministic: Boolean = true) extends InvokeLike { + isDeterministic: Boolean = true, + scalarFunctionName: Option[String] = None, Review Comment: @cloud-fan @sunchao Although adding `ScalarFunction` as a new parameter is convenient, it makes StaticInvoke look very strange. We already call the `scalarFunc.getClass`, `scalarFunc.resultType()`, `scalarFunc.isResultNullable` and `scalarFunc.isDeterministic` before passed the new `ScalarFunction`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org