allisonwang-db commented on code in PR #43014: URL: https://github.com/apache/spark/pull/43014#discussion_r1331920397
########## python/pyspark/sql/tests/connect/test_connect_basic.py: ########## @@ -1237,13 +1237,23 @@ def test_sql(self): self.assertEqual(1, len(pdf.index)) def test_sql_with_named_args(self): - df = self.connect.sql("SELECT * FROM range(10) WHERE id > :minId", args={"minId": 7}) - df2 = self.spark.sql("SELECT * FROM range(10) WHERE id > :minId", args={"minId": 7}) + from pyspark.sql.functions import create_map, lit + from pyspark.sql.connect.functions import lit as clit + from pyspark.sql.connect.functions import create_map as ccreate_map Review Comment: @zhengruifeng just wondering should `SF` and `CF` be capitalized here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org