zhengruifeng commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1333829755
########## python/pyspark/sql/connect/plan.py: ########## @@ -1192,6 +1192,7 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: assert self._child is not None plan = proto.Relation() + plan.common.plan_id = self._child._plan_id Review Comment: you change here is fine, it is equivalent to `_create_proto_relation` I notice there are a few places not using `_create_proto_relation`, I will check and modify them in separate work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org