LuciferYang commented on code in PR #43008:
URL: https://github.com/apache/spark/pull/43008#discussion_r1333875577
##########
docs/_plugins/copy_api_dirs.rb:
##########
@@ -26,8 +26,8 @@
curr_dir = pwd
cd("..")
- puts "Running 'build/sbt -Pkinesis-asl clean compile unidoc' from " + pwd
+ "; this may take a few minutes..."
- system("build/sbt -Pkinesis-asl clean compile unidoc") || raise("Unidoc
generation failed")
+ puts "Running 'build/sbt -Pscala-2.13 -Pkinesis-asl clean compile unidoc'
from " + pwd + "; this may take a few minutes..."
Review Comment:
When we execute `dev/change-scala-version.sh 2.13`, it simultaneously
modifies both `copy_api_dirs.rb` and `mima` files, adding these `-Pscala-2.13`.
In this PR, I didn't clean them up. It seems we could add a follow-up to clear
these unnecessary `-Pscala-2.13`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
