LuciferYang commented on code in PR #43049:
URL: https://github.com/apache/spark/pull/43049#discussion_r1333898761
##########
dev/mima:
##########
@@ -24,9 +24,9 @@ set -e
FWDIR="$(cd "`dirname "$0"`"/..; pwd)"
cd "$FWDIR"
-SPARK_PROFILES=${1:-"-Pscala-2.13 -Pmesos -Pkubernetes -Pyarn
-Pspark-ganglia-lgpl -Pkinesis-asl -Phive-thriftserver -Phive"}
-TOOLS_CLASSPATH="$(build/sbt -Pscala-2.13 -DcopyDependencies=false "export
tools/fullClasspath" | grep jar | tail -n1)"
-OLD_DEPS_CLASSPATH="$(build/sbt -Pscala-2.13 -DcopyDependencies=false
$SPARK_PROFILES "export oldDeps/fullClasspath" | grep jar | tail -n1)"
Review Comment:
While cleaning this up, I suggest removing `2.13` from `VALID_VERSIONS` in
the `change-scala-version.sh` script, otherwise if we execute
`dev/change-scala-version.sh 2.13`, these files will generate some unnecessary
git diff.
https://github.com/apache/spark/blame/5f643ee1444d41ca78ef397d9675efac550a6967/dev/change-scala-version.sh#L22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
