dongjoon-hyun commented on code in PR #43059:
URL: https://github.com/apache/spark/pull/43059#discussion_r1334632610
##########
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala:
##########
@@ -51,7 +51,7 @@ abstract class BenchmarkBase {
val regenerateBenchmarkFiles: Boolean =
System.getenv("SPARK_GENERATE_BENCHMARK_FILES") == "1"
if (regenerateBenchmarkFiles) {
val version = System.getProperty("java.version").split("\\D+")(0).toInt
- val jdkString = if (version > 8) s"-jdk$version" else ""
+ val jdkString = if (version > 17) s"-jdk$version" else ""
Review Comment:
Hmm, I verified Java 8, it seems to fail in the other part.
```
$ SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "core/Test/runMain
org.apache.spark.serializer.KryoBenchmark"
...
[error] '17' is not a valid choice for '-target'
[error] bad option: '-target:17'
[error] (tags / Compile / compileIncremental) Compilation failed
[error] Total time: 39 s, completed Sep 22, 2023 10:03:31 AM
```
##########
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala:
##########
@@ -51,7 +51,7 @@ abstract class BenchmarkBase {
val regenerateBenchmarkFiles: Boolean =
System.getenv("SPARK_GENERATE_BENCHMARK_FILES") == "1"
if (regenerateBenchmarkFiles) {
val version = System.getProperty("java.version").split("\\D+")(0).toInt
- val jdkString = if (version > 8) s"-jdk$version" else ""
+ val jdkString = if (version > 17) s"-jdk$version" else ""
Review Comment:
Hmm, I re-verified Java 8, it seems to fail in the other part.
```
$ SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "core/Test/runMain
org.apache.spark.serializer.KryoBenchmark"
...
[error] '17' is not a valid choice for '-target'
[error] bad option: '-target:17'
[error] (tags / Compile / compileIncremental) Compilation failed
[error] Total time: 39 s, completed Sep 22, 2023 10:03:31 AM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
