MaxGekk commented on code in PR #43314:
URL: https://github.com/apache/spark/pull/43314#discussion_r1356985023
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/artifact/SparkConnectArtifactManager.scala:
##########
@@ -82,6 +83,40 @@ class SparkConnectArtifactManager(sessionHolder:
SessionHolder) extends Logging
*/
def getSparkConnectPythonIncludes: Seq[String] =
pythonIncludeList.asScala.toSeq
+ private def areFilesEqual(path1: Path, path2: Path): Boolean = {
Review Comment:
Can't you re-use some functions from libs like Apache Common:
`IOUtils::contentEquals` or `FileUtils.contentEquals`. Or there is some reason
to don't do that. Please, clarify that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
