HyukjinKwon commented on code in PR #43368: URL: https://github.com/apache/spark/pull/43368#discussion_r1359991579
########## sql/api/src/main/scala/org/apache/spark/sql/catalyst/analysis/alreadyExistException.scala: ########## @@ -31,7 +31,7 @@ class DatabaseAlreadyExistsException(db: String) extends NamespaceAlreadyExistsException(Array(db)) // any changes to this class should be backward compatible as it may be used by external connectors -class NamespaceAlreadyExistsException private( +class NamespaceAlreadyExistsException private[sql]( Review Comment: `catalyst` is already an internal package (https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/package.scala#L21-L22) so we can remove `private[sql]` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
