hasnain-db opened a new pull request, #43387:
URL: https://github.com/apache/spark/pull/43387

   ### What changes were proposed in this pull request?
   
   This change ensures that RPC SSL options settings inheritance works properly 
after https://github.com/apache/spark/pull/43238 - we pass `sslOptions` 
wherever we call `fromSparkConf`.
   
   In addition to that minor mechanical change, duplicate/add tests for every 
place that calls this method, to add a test case that runs with SSL support in 
the config.
   
   ### Why are the changes needed?
   
   These changes are needed to ensure that the RPC SSL functionality can work 
properly with settings inheritance. In addition, through these tests we can 
ensure that any changes to these modules are also tested with SSL support and 
avoid regressions in the future.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   Full integration testing also done as part of 
https://github.com/apache/spark/pull/42685
   
   Added some tests and ran them:
   
   ```
   build/sbt
   > project core
   > testOnly org.apache.spark.*Ssl*
   > testOnly org.apache.spark.network.netty.NettyBlockTransferSecuritySuite
   ```
   
   and
   
   ```
   build/sbt -Pyarn
   > project yarn
   > testOnly 
org.apache.spark.network.yarn.SslYarnShuffleServiceWithRocksDBBackendSuite
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to