tigrulya-exe commented on code in PR #43463: URL: https://github.com/apache/spark/pull/43463#discussion_r1366881061
########## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala: ########## @@ -197,11 +233,35 @@ object TestPaths { ) ) + val txtRelativeHarPath = new Path("/test.txt") + val csvRelativeHarPath = new Path("/test.csv") + val jsonRelativeHarPath = new Path("/test.json") + val parquetRelativeHarPath = new Path("/test.parquet") + val orcRelativeHarPath = new Path("/test.orc") + val globeRelativeHarPath = new Path("/test.*") Review Comment: They're needed to test globe path. I decided to reuse har from `DataFrameReaderWriterSuite` tests instead of creating new archive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org