Yikun commented on code in PR #56:
URL: https://github.com/apache/spark-docker/pull/56#discussion_r1369408222
##########
add-dockerfiles.sh:
##########
@@ -26,13 +26,17 @@
# - Add 3.3.1 dockerfiles:
# $ ./add-dockerfiles.sh 3.3.1
-VERSION=${1:-"3.3.0"}
+VERSION=${1:-"3.5.0"}
TAGS="
scala2.12-java11-python3-r-ubuntu
scala2.12-java11-python3-ubuntu
scala2.12-java11-r-ubuntu
scala2.12-java11-ubuntu
+scala2.12-java17-python3-r-ubuntu
+scala2.12-java17-python3-ubuntu
+scala2.12-java17-r-ubuntu
+scala2.12-java17-ubuntu
Review Comment:
Because we only add after 3.5 version, so we should skip 3.3 / 3.4 version.
So seems we need some thing like below:
```shell
if ! echo $VERSION | grep -Eq "^3.3|^3.4"; then
TAGS+="
scala2.12-java17-python3-r-ubuntu
scala2.12-java17-python3-ubuntu
scala2.12-java17-r-ubuntu
scala2.12-java17-ubuntu
"
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
