rangadi commented on code in PR #43493:
URL: https://github.com/apache/spark/pull/43493#discussion_r1370711411
##########
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufCatalystDataConversionSuite.scala:
##########
@@ -138,6 +138,7 @@ class ProtobufCatalystDataConversionSuite
data != null &&
(data.get(0) == defaultValue ||
(dt.fields(0).dataType == BinaryType &&
+ data.get(0) != null &&
Review Comment:
We should allow null value for the field. I.e. change this to:
```scala
data.get(0) == null || data.get(0).asInstanceOf[Array[Byte]].isEmpty
```
I will test on my side to ensure this test stays stable with range of `seed`
values.
cc: @HeartSaVioR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
