zhaomin1423 commented on code in PR #43502:
URL: https://github.com/apache/spark/pull/43502#discussion_r1371083522
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/RocksDBIterator.java:
##########
@@ -272,4 +269,39 @@ static int compare(byte[] a, byte[] b) {
return a.length - b.length;
}
+ static class ResourceCleaner implements Runnable {
+
+ private final RocksIterator rocksIterator;
+
+ private final AtomicReference<org.rocksdb.RocksDB> _db;
+
+ private final ConcurrentLinkedQueue<Reference<RocksDBIterator<?>>>
iteratorTracker;
+
+ public ResourceCleaner(RocksIterator rocksIterator,
+ AtomicReference<org.rocksdb.RocksDB> _db,
+ ConcurrentLinkedQueue<Reference<RocksDBIterator<?>>> iteratorTracker) {
+ this.rocksIterator = rocksIterator;
+ this._db = _db;
+ this.iteratorTracker = iteratorTracker;
+ }
+
+ @Override
+ public void run() {
+ synchronized (this._db) {
+ org.rocksdb.RocksDB _db = this._db.get();
+ if (_db == null) {
+ return;
+ }
+ rocksIterator.close();
+ }
+ iteratorTracker.removeIf(ref -> {
+ RocksDBIterator<?> rocksDBIterator = ref.get();
+ if (rocksDBIterator != null &&
rocksIterator.equals(rocksDBIterator.it)) {
+ return true;
+ } else {
+ return false;
+ }
+ });
Review Comment:
thanks, fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
