HyukjinKwon commented on code in PR #43537: URL: https://github.com/apache/spark/pull/43537#discussion_r1372639788
########## python/pyspark/sql/connect/session.py: ########## @@ -694,11 +694,11 @@ def streams(self) -> "StreamingQueryManager": streams.__doc__ = PySparkSession.streams.__doc__ def __getattr__(self, name: str) -> Any: - if name in ["_jsc", "_jconf", "_jvm", "_jsparkSession"]: + if name in ["_jsc", "_jconf", "_jvm", "_jsparkSession", "sparkContext"]: raise PySparkAttributeError( error_class="JVM_ATTRIBUTE_NOT_SUPPORTED", message_parameters={"attr_name": name} ) - elif name in ["newSession", "sparkContext"]: + elif name in ["newSession"]: Review Comment: Let's also do `newSession`. Can we fix them all since we're here? I think we shouldn't say it's not implemented but unsupported explicitly. e.g., `DataFrame.rdd` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org