hasnain-db opened a new pull request, #43541:
URL: https://github.com/apache/spark/pull/43541

   ### What changes were proposed in this pull request?
   
   This integrates SSL support into TransportContext and related modules so 
that the RPC SSL functionality can work when properly configured.
   
   ### Why are the changes needed?
   
   This is needed in order to support SSL for RPC connections.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   CI
   
   Ran the following tests:
   
   ```
   build/sbt -P yarn
   > project network-common
   > testOnly
   > project network-shuffle
   > testOnly
   > project core
   > testOnly *Ssl*
   > project yarn
   > testOnly 
org.apache.spark.network.yarn.SslYarnShuffleServiceWithRocksDBBackendSuite
   ```
   
   I verified traffic was encrypted using TLS using two mechanisms:
   
   * Enabled trace level logging for Netty and JDK SSL and saw logs confirming 
TLS handshakes were happening
   * I ran wireshark on my machine and snooped on traffic while sending queries 
shuffling a fixed string. Without any encryption, I could find that string in 
the network traffic. With this encryption enabled, that string did not show up, 
and wireshark logs confirmed a TLS handshake was happening.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to