mridulm commented on code in PR #43541: URL: https://github.com/apache/spark/pull/43541#discussion_r1375373421
########## common/network-common/src/main/java/org/apache/spark/network/TransportContext.java: ########## @@ -189,15 +204,32 @@ public TransportChannelHandler initializePipeline(SocketChannel channel) { */ public TransportChannelHandler initializePipeline( SocketChannel channel, - RpcHandler channelRpcHandler) { + RpcHandler channelRpcHandler, + boolean isClient) { try { TransportChannelHandler channelHandler = createChannelHandler(channel, channelRpcHandler); ChannelPipeline pipeline = channel.pipeline(); + if (nettyLogger.getLoggingHandler() != null) { pipeline.addLast("loggingHandler", nettyLogger.getLoggingHandler()); } + + if (sslEncryptionEnabled()) { + SslHandler sslHandler; + try { + sslHandler = new SslHandler( + sslFactory.createSSLEngine(isClient, pipeline.channel().alloc())); + } catch (Exception e) { + throw new RuntimeException("Error creating Netty SslHandler", e); Review Comment: ~This is still `RuntimeException`~ I was looking at outdated diff :-( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org