bjornjorgensen commented on code in PR #43589:
URL: https://github.com/apache/spark/pull/43589#discussion_r1376764990
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStepSuite.scala:
##########
@@ -95,7 +95,7 @@ class MountVolumesFeatureStepSuite extends SparkFunSuite {
"/tmp",
"",
true,
- KubernetesPVCVolumeConf("pvc-spark-SPARK_EXECUTOR_ID", Some("fast"),
Some("512mb"))
+ KubernetesPVCVolumeConf("pvc-spark-SPARK_EXECUTOR_ID", Some("fast"),
Some("512m"))
Review Comment:
Should it be "512M" instead of "512m" ?
"Pay attention to the case of the suffixes. If you request 400m of
ephemeral-storage, this is a request for 0.4 bytes. Someone who types that
probably meant to ask for 400 mebibytes (400Mi) or 400 megabytes (400M)."
https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
