LuciferYang commented on code in PR #43502:
URL: https://github.com/apache/spark/pull/43502#discussion_r1377001116
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java:
##########
@@ -182,23 +189,21 @@ public boolean skip(long n) {
@Override
public synchronized void close() throws IOException {
- db.notifyIteratorClosed(this);
if (!closed) {
- it.close();
- closed = true;
- next = null;
+ try {
+ cleanable.clean();
Review Comment:
@zhaomin1423 Overall, we want to make the close method of `RocksDBIterator`
look similar. The `notifyIteratorClosed ` method in `RocksDB` needs to be
retained (it can be refactored for reuse by `ResourceCleaner`).
```
public synchronized void close() throws IOException {
db.notifyIteratorClosed(this);
if (!closed) {
it.close();
closed = true;
next = null;
this.cancelXXX();
}
}
```
The purpose of `this.cancelXXX();` is to prevent `ResourceCleaner` from
executing repeatedly when manually closed.
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java:
##########
@@ -182,23 +189,21 @@ public boolean skip(long n) {
@Override
public synchronized void close() throws IOException {
- db.notifyIteratorClosed(this);
if (!closed) {
- it.close();
- closed = true;
- next = null;
+ try {
+ cleanable.clean();
Review Comment:
@zhaomin1423 Overall, we want to make the close method of `RocksDBIterator`
look similar. The `notifyIteratorClosed ` method in `RocksDB` needs to be
retained (it can be refactored for reuse by `ResourceCleaner`).
```
public synchronized void close() throws IOException {
db.notifyIteratorClosed(this);
if (!closed) {
it.close();
closed = true;
next = null;
this.cancelXXX();
}
}
```
The purpose of `this.cancelXXX();` is to prevent `ResourceCleaner` from
executing repeatedly when manually closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
