cloud-fan commented on code in PR #43334:
URL: https://github.com/apache/spark/pull/43334#discussion_r1377166456
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/trees/QueryContexts.scala:
##########
@@ -28,19 +28,20 @@ case class SQLQueryContext(
sqlText: Option[String],
originObjectType: Option[String],
originObjectName: Option[String]) extends QueryContext {
+ override val contextType = QueryContextType.SQL
- override val objectType = originObjectType.getOrElse("")
- override val objectName = originObjectName.getOrElse("")
- override val startIndex = originStartIndex.getOrElse(-1)
- override val stopIndex = originStopIndex.getOrElse(-1)
Review Comment:
why remove `override`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
