gengliangwang commented on PR #43609: URL: https://github.com/apache/spark/pull/43609#issuecomment-1787964921
@dongjoon-hyun I like the idea. In the long term, the major concern is that there can be issues if a protobuf serializer is not implemented properly in handling null string values. From https://issues.apache.org/jira/browse/SPARK-41053: <img width="1482" alt="image" src="https://github.com/apache/spark/assets/1097932/fbff6dff-314e-48c6-a868-f51ac7920d9a";> It would be great if we could have some tests/rules on these serializers against string fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
