viirya commented on code in PR #43638: URL: https://github.com/apache/spark/pull/43638#discussion_r1380704238
########## core/src/test/scala/org/apache/spark/deploy/history/EventLogFileWritersSuite.scala: ########## @@ -66,7 +66,7 @@ abstract class EventLogFileWritersSuite extends SparkFunSuite with LocalSparkCon conf.set(EVENT_LOG_DIR, testDir.toString) // default config - buildWriterAndVerify(conf, classOf[SingleEventLogFileWriter]) + buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter]) conf.set(EVENT_LOG_ENABLE_ROLLING, true) buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter]) Review Comment: ```suggestion ``` ########## core/src/test/scala/org/apache/spark/deploy/history/EventLogFileWritersSuite.scala: ########## @@ -66,7 +66,7 @@ abstract class EventLogFileWritersSuite extends SparkFunSuite with LocalSparkCon conf.set(EVENT_LOG_DIR, testDir.toString) // default config - buildWriterAndVerify(conf, classOf[SingleEventLogFileWriter]) + buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter]) conf.set(EVENT_LOG_ENABLE_ROLLING, true) Review Comment: Is it redundant then? ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org