beliefer commented on code in PR #43627:
URL: https://github.com/apache/spark/pull/43627#discussion_r1382560338
##########
core/src/main/scala/org/apache/spark/shuffle/ShuffleManager.scala:
##########
@@ -17,7 +17,30 @@
package org.apache.spark.shuffle
-import org.apache.spark.{ShuffleDependency, TaskContext}
+import java.util.Locale
+
+import org.apache.spark.{ShuffleDependency, SparkConf, TaskContext}
+import org.apache.spark.internal.config
+import org.apache.spark.util.Utils
+
+/**
+ * Utility companion object to create a ShuffleManager given a spark
configuration.
+ */
+private[spark] object ShuffleManager {
Review Comment:
Shall we put the companion object at the last?
##########
core/src/main/scala/org/apache/spark/SparkEnv.scala:
##########
@@ -402,7 +405,7 @@ object SparkEnv extends Logging {
None
}, blockManagerInfo,
mapOutputTracker.asInstanceOf[MapOutputTrackerMaster],
- shuffleManager,
+ shuffleBlockGetterFn,
Review Comment:
Why not define `shuffleBlockGetterFn` in `BlockManagerMasterEndpoint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
