tgravescs commented on code in PR #43494:
URL: https://github.com/apache/spark/pull/43494#discussion_r1384004018
##########
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala:
##########
@@ -191,7 +191,10 @@ private[spark] class CoarseGrainedExecutorBackend(
} else {
val taskDesc = TaskDescription.decode(data.value)
logInfo("Got assigned task " + taskDesc.taskId)
- taskResources.put(taskDesc.taskId, taskDesc.resources)
+ // Convert resources amounts into ResourceInformation
+ val resources = taskDesc.resources.map { case (rName,
addressesAmounts) =>
+ rName -> new ResourceInformation(rName,
addressesAmounts.keys.toSeq.sorted.toArray)}
+ taskResources.put(taskDesc.taskId, resources)
Review Comment:
I don't think taskResources is needed at all anymore. Lets remove it unless
you see it being used for something I'm missing. It was used in the
statusUpdate call below that you removed. I actually think it wasn't needed
even before (changed in Spark 3.4) that since the taskDescription and
runningTasks has the same information and is now accessible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
