allisonwang-db commented on code in PR #43682: URL: https://github.com/apache/spark/pull/43682#discussion_r1384161755
########## python/pyspark/worker.py: ########## @@ -995,6 +995,8 @@ def verify_result(result): def func(*a: Any) -> Any: try: return f(*a) + except StopIteration: + raise Review Comment: Should we use something similar to `fail_on_stopiteration`? ``` except StopIteration as exc: raise PySparkRuntimeError( error_class="STOP_ITERATION_OCCURRED", message_parameters={ "exc": str(exc), }, ) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org