grundprinzip commented on code in PR #43664: URL: https://github.com/apache/spark/pull/43664#discussion_r1385540515
########## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectStubState.scala: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.connect.client + +import com.google.protobuf.GeneratedMessageV3 +import io.grpc.ManagedChannel +import io.grpc.stub.StreamObserver + +import org.apache.spark.internal.Logging + +// This is common state shared between the blocking and non-blocking stubs. +// +// The common logic is responsible to verify the integrity of the response. The invariant is +// that the same stub instance is used for all requests from the same client. In addition, +// this class provides access to the commonly configured retry policy and exception conversion +// logic. +class SparkConnectStubState( + channel: ManagedChannel, + val retryPolicy: GrpcRetryHandler.RetryPolicy) + extends Logging { + + // Responsible to convert the GRPC Status exceptions into Spark exceptions. + lazy val exceptionConverter: GrpcExceptionConverter = new GrpcExceptionConverter(channel) + + // Manages the retry handler logic used by the stubs. + lazy val retryHandler = new GrpcRetryHandler(retryPolicy) + + // Server side session ID, used to detect if the server side session changed. This is set upon + // receiving the first response from the server. This value is used only for executions that + // do not use server-side streaming. + private var serverSideSessionId: Option[String] = None + + def verifyResponse[RespT <: GeneratedMessageV3](fn: => RespT): RespT = { Review Comment: Done ########## connector/connect/server/src/test/scala/org/apache/spark/sql/connect/service/SparkConnectSessionHolderSuite.scala: ########## @@ -232,58 +282,9 @@ class SparkConnectSessionHolderSuite extends SharedSparkSession { assert(spark.streams.listListeners().length == 1) // only process termination listener } finally { SparkConnectService.stop() + Thread.sleep(4.seconds.toMillis) // remove process termination listener spark.streams.listListeners().foreach(spark.streams.removeListener) } } - - test("python listener process: process terminates after listener is removed") { Review Comment: Removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
