wangyum commented on code in PR #43841:
URL: https://github.com/apache/spark/pull/43841#discussion_r1396593112
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala:
##########
@@ -68,7 +68,13 @@ case class EnsureRequirements(
case (child, distribution) =>
val numPartitions = distribution.requiredNumPartitions
.getOrElse(conf.numShufflePartitions)
- ShuffleExchangeExec(distribution.createPartitioning(numPartitions),
child, shuffleOrigin)
+ // Avoid generating redundant ShuffleExchangeExec node
+ val shuffleChild = child match {
+ case s: ShuffleExchangeExec => s.child
+ case other => other
+ }
+ ShuffleExchangeExec(
+ distribution.createPartitioning(numPartitions), shuffleChild,
shuffleOrigin)
Review Comment:
@ulysses-you It only takes effect if there are no operators between two
shuffles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
