EnricoMi commented on PR #43519:
URL: https://github.com/apache/spark/pull/43519#issuecomment-1821529980

   > name is unique but df can be self-joined and observation will be 
duplicated.
   
   That sounds like an unrelated edge case. Example in the description is not a 
self-join of an observed dataset. And this PR does not fix this edge case: The 
self-joined dataset still contains two identical `CollectMetrics` with the same 
`dataframeId`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to