Hisoka-X commented on code in PR #42398: URL: https://github.com/apache/spark/pull/42398#discussion_r1405586741
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ########## @@ -2214,6 +2214,30 @@ class AstBuilder extends DataTypeAstBuilder with SQLConfHelper with Logging { } } + /** + * Create a ListAgg expression. + */ + override def visitListAgg(ctx: ListAggContext): AnyRef = { + val column = expression(ctx.aggEpxr) + val sortOrder = visitSortItem(ctx.sortItem) + val isDistinct = Option(ctx.setQuantifier()).exists(_.DISTINCT != null) + if (!column.semanticEquals(sortOrder.child) && isDistinct) { + throw QueryCompilationErrors.functionAndOrderExpressionMismatchError("LISTAGG", column, + sortOrder.child) + } + val delimiter = if (ctx.delimiter != null) Literal(ctx.delimiter.getText) else Literal(",") Review Comment: fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org