mridulm commented on code in PR #43954: URL: https://github.com/apache/spark/pull/43954#discussion_r1409488053
########## core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala: ########## @@ -1871,21 +1871,6 @@ private[spark] class DAGScheduler( markStageAsFinished(resultStage) cancelRunningIndependentStages(job, s"Job ${job.jobId} is finished.") cleanupStateForJobAndIndependentStages(job) - try { - // killAllTaskAttempts will fail if a SchedulerBackend does not implement - // killTask. - logInfo(s"Job ${job.jobId} is finished. Cancelling potential speculative " + - "or zombie tasks for this job") - // ResultStage is only used by this job. It's safe to kill speculative or - // zombie tasks in this stage. - taskScheduler.killAllTaskAttempts( Review Comment: See my [comment above](https://github.com/apache/spark/pull/43954/files#r1409479495), unless we have other changes, we will have to revert this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org