cloud-fan commented on code in PR #44079:
URL: https://github.com/apache/spark/pull/44079#discussion_r1410968044
##########
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala:
##########
@@ -503,7 +503,7 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
*/
override def databaseExists(dbName: String): Boolean = {
try {
- getDatabase(dbName)
+ makeDatabase(None, dbName)
Review Comment:
I disagree with this change. There is nearly no benefit and it's kind of
encouraging people to never use parameter default values but just call the base
function with all parameter values specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
